Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error with assume-no-moving-gc #9

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix error with assume-no-moving-gc #9

merged 1 commit into from
Oct 25, 2023

Conversation

Abuelodelanada
Copy link
Contributor

Issue

This PR fixes canonical/cos-tool-snap#1

How to test it:

  1. Build cos-tool: go build --ldflags '-extldflags "-static"'
  2. Run it to check the error is gone:
$ ./cos-tool 

NAME:
   cos-tool - Validates Prometheus and Loki expressions, adds Juju Topology to label matchers

USAGE:
   cos-tool [global options] command [command options] [arguments...]

COMMANDS:
   transform, t                          
   validate-rules, v, lint, l, validate  
   validate-config                       
   help, h                               Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --format promql|logql, -f promql|logql  Inject expressions into promql|logql (default: "promql")
   --help, -h

@simskij
Copy link
Member

simskij commented Oct 25, 2023

Seems like you updated all deps, not only the assume-no-gc one, so this will require some additional work to fix the unit tests before being ready to merge.

@Abuelodelanada
Copy link
Contributor Author

Seems like you updated all deps, not only the assume-no-gc one, so this will require some additional work to fix the unit tests before being ready to merge.

I wanted to take the opportunity to update everything. The problem are not the tests. They fail with 1.18 in the CI, on localhost with 1.21 they pass.

Anyway, now only assume-no-gc is updated, we can update all deps in a next PR.

@Abuelodelanada Abuelodelanada merged commit 6a73d49 into main Oct 25, 2023
2 checks passed
@Abuelodelanada Abuelodelanada deleted the snap branch October 25, 2023 21:24
@Abuelodelanada Abuelodelanada requested a review from a team October 25, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sed-i sed-i sed-i approved these changes

@lucabello lucabello Awaiting requested review from lucabello

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti

@dstathis dstathis Awaiting requested review from dstathis

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.21 error
3 participants
@Abuelodelanada @simskij @sed-i